minor(test): strengthen sort-merge join spilling coverage - #23988
Open
buraksenn wants to merge 2 commits into
Open
minor(test): strengthen sort-merge join spilling coverage#23988buraksenn wants to merge 2 commits into
buraksenn wants to merge 2 commits into
Conversation
buraksenn
force-pushed
the
smj-spill-test-coverage
branch
from
July 30, 2026 06:45
500ec34 to
f45a5cd
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23988 +/- ##
==========================================
+ Coverage 80.69% 80.75% +0.05%
==========================================
Files 1095 1096 +1
Lines 372626 373588 +962
Branches 372626 373588 +962
==========================================
+ Hits 300700 301687 +987
+ Misses 53978 53897 -81
- Partials 17948 18004 +56 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Contuining the work after #23947. Now
SortMergeJoinExecsupports spilling under memory pressure, but existing tests do not consistently assert that spilling occurs.What changes are included in this PR?
Adds spill fuzz coverage, constrained-memory stress tests for materializing joins, and process-isolated memory-limit validation.
Are these changes tested?
test only change and it can be tested via:
Are there any user-facing changes?
no test only change