chore: cleanup OrderedPartialAggregateStream more - #24012
Open
rluvaton wants to merge 1 commit into
Open
Conversation
2010YOUY01
approved these changes
Jul 31, 2026
2010YOUY01
left a comment
2010YOUY01
left a comment
Contributor
There was a problem hiding this comment.
Thank you, LGTM.
Left one optional suggestion for further cleaning it up.
| .take() | ||
| .expect("OrderedPartialAggregateStream state should not be None"); | ||
|
|
||
| self.handle_reading_input(&mut table, &mut emitter).await?; |
Contributor
There was a problem hiding this comment.
I think we could even further move the surrounding setup/cleanup code into this function similarly, then the entry point will only have
self.handle_reading_input(emitter)
self.handle_draining_final(emitter)
Each is representing a execution state, this organization I think map really close to the idea behind it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
My original refactor PR did this but I can just move table and cleanup more
OrderedPartialAggregateStreamto generators for readability #23951What changes are included in this PR?
remove weird non optimizing thing
Are these changes tested?
existing tests
Are there any user-facing changes?
no