chore(PartialReduceHashAggregateStream): convert to async generators and cleanup - #24015
Open
rluvaton wants to merge 1 commit into
Open
chore(PartialReduceHashAggregateStream): convert to async generators and cleanup#24015rluvaton wants to merge 1 commit into
PartialReduceHashAggregateStream): convert to async generators and cleanup#24015rluvaton wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24015 +/- ##
========================================
Coverage 80.84% 80.85%
========================================
Files 1096 1099 +3
Lines 373936 374271 +335
Branches 373936 374271 +335
========================================
+ Hits 302313 302610 +297
- Misses 53584 53608 +24
- Partials 18039 18053 +14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
13 tasks
Contributor
|
Could we delay those cleanup PRs after #22710 is functionally complete? Now we're in a inconsistent state, and I think it's better to fully remove the legacy implementation sooner, and next we can continue cleaning things up. I estimate it's ~3 PRs away from that, I'll update in the EPIC issue when it's ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to:
Rationale for this change
Cleanup the code and remove state
What changes are included in this PR?
changed to async generator and remove unneeded code due to that
Are these changes tested?
existing tests
Are there any user-facing changes?
nope