Skip to content

chore(PartialReduceHashAggregateStream): convert to async generators and cleanup - #24015

Open
rluvaton wants to merge 1 commit into
apache:mainfrom
rluvaton:move-partial-reduce-agg-stream
Open

chore(PartialReduceHashAggregateStream): convert to async generators and cleanup#24015
rluvaton wants to merge 1 commit into
apache:mainfrom
rluvaton:move-partial-reduce-agg-stream

Conversation

@rluvaton

Copy link
Copy Markdown
Member

Which issue does this PR close?

Related to:

Rationale for this change

Cleanup the code and remove state

What changes are included in this PR?

changed to async generator and remove unneeded code due to that

Are these changes tested?

existing tests

Are there any user-facing changes?

nope

@github-actions github-actions Bot added the physical-plan Changes to the physical-plan crate label Jul 30, 2026
@rluvaton
rluvaton marked this pull request as ready for review July 30, 2026 19:01
@rluvaton
rluvaton requested a review from 2010YOUY01 July 30, 2026 19:01
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 79.03226% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.85%. Comparing base (541caab) to head (d0c2479).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...sical-plan/src/aggregates/partial_reduce_stream.rs 78.68% 5 Missing and 8 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #24015    +/-   ##
========================================
  Coverage   80.84%   80.85%            
========================================
  Files        1096     1099     +3     
  Lines      373936   374271   +335     
  Branches   373936   374271   +335     
========================================
+ Hits       302313   302610   +297     
- Misses      53584    53608    +24     
- Partials    18039    18053    +14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@2010YOUY01

Copy link
Copy Markdown
Contributor

Could we delay those cleanup PRs after #22710 is functionally complete?

Now we're in a inconsistent state, and I think it's better to fully remove the legacy implementation sooner, and next we can continue cleaning things up. I estimate it's ~3 PRs away from that, I'll update in the EPIC issue when it's ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

physical-plan Changes to the physical-plan crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants