fix: ensure native query statusCode is 403 for blocklist#19745
Open
jtuglu1 wants to merge 1 commit into
Open
Conversation
jtuglu1
force-pushed
the
fix-query-blocklist-status-code-bug
branch
from
July 24, 2026 23:37
6a2bbab to
a559622
Compare
abhishekrb19
approved these changes
Jul 25, 2026
maytasm
approved these changes
Jul 25, 2026
| // Handled separately from QueryException so that the exception's own category (for example FORBIDDEN for a | ||
| // blocklisted query) determines the status code. Wrapping it below would erase that and report a 500. | ||
| return QueryResultPusher.handleDruidExceptionBeforeResponseStarted( | ||
| e, |
Contributor
There was a problem hiding this comment.
Do we need to transform using serverConfig.getErrorResponseTransformStrategy()
| return QueryResultPusher.handleDruidExceptionBeforeResponseStarted( | ||
| e, | ||
| MediaType.valueOf(io.getResponseWriter().getResponseType()), | ||
| ImmutableMap.of() |
Contributor
There was a problem hiding this comment.
Do we need to add QUERY_ID_RESPONSE_HEADER to this Map?
FrankChen021
left a comment
FrankChen021
left a comment
Member
There was a problem hiding this comment.
I have reviewed the code for correctness, edge cases, concurrency, and integration risks; no issues found.
Reviewed 3 of 3 changed files.
This is an automated review by Codex GPT-5.6-Sol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This makes sure that any DruidExceptions thrown during query processing are correctly propagated with the correct status code for native queries.
Release note
Ensure native query statusCode is 403 for query blocklist
This PR has: