fix(axis): Show min/max split line for all axis types#21579
Open
sebastianludwig wants to merge 4 commits intoapache:masterfrom
Open
fix(axis): Show min/max split line for all axis types#21579sebastianludwig wants to merge 4 commits intoapache:masterfrom
sebastianludwig wants to merge 4 commits intoapache:masterfrom
Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Add the missing implementation of
splitLine.showMinLine/.showMaxLineto radius, angle and single axis. Also add support for these properties toaxisLinefor polar angle axis.Details
Before: What was the problem?
#20114 added
splitLine.showMinLineand.showMaxLineand implemented it for the cartesian axis. The current documentation shows the option to be supported for other axis as well:However there was simply no implementation in place. This PR fixes that.
Also, while on it, I also added support for these properties to
axisLinefor polar angle axis.After: How does it behave after the fixing?
The split line fix
The axis line feature
Document Info
One of the following should be checked.
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Merging options
Other information
This is my first PR in this repo. Please let me know if I missed some of the conventions.