fix(marker): fix markArea position alignment when axis is inverse#21654
Open
Raman-Katiyar wants to merge 1 commit into
Open
fix(marker): fix markArea position alignment when axis is inverse#21654Raman-Katiyar wants to merge 1 commit into
Raman-Katiyar wants to merge 1 commit into
Conversation
|
Thanks for your contribution! Please DO NOT commit the files in dist, i18n, and ssr/client/dist folders in a non-release pull request. These folders are for release use only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fixes the markArea positioning alignment bug when xAxis or yAxis category axis is set to inverse: true by refactoring the core to use axis.dataToCoord.
Fixed issues
Details
Before: What was the problem?
When
inverse: trueis set on category axes, themarkAreabounding box misaligns or breaks completely because the old code hardcoded a manual index increment (targetTickId += 1) and a sequential coordinate scanning loop that assumed strictly ascending ticks.After: How does it behave after the fixing?
The manual loops and hardcoded index shifting were refactored to use ECharts' core
axis.dataToCoordmechanism. It seamlessly resolves the bounding coordinates for both regular and inverse category axis configurations accurately, keeping the markArea perfectly aligned.Document Info
One of the following should be checked.
Misc
Security Checking
ZRender Changes
Related test cases or examples to use the new APIs
N.A.
Merging options
Other information