FINERACT-2634: Implement Registration Feature#13
Merged
Conversation
- created registration feature - created user feature service - created fineract client - added custom exceptions and handling - removed gitkeep placeholders - removed ping feature - expanded liquibase user columns - implemented cqrs separation - added command/query aspects for cross cutting concerns
- added cucumber tests for some happy paths - added otp feature service - added cucumber infrastructure for mailpit client
Aman-Mittal
reviewed
Jun 8, 2026
- used assertion constants instead of hardcoded strings when applicable - added FineractHeaders.java for header constants - small code quality fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/FINERACT-2634
Summary
The first feature to be implemented is user registration. I have below implemented full OTP and Identity Verification flow along with CQRS as requested.
Some architectural decisions include Spring Aspects for cross cutting concerns over a command bus orchestration layer, full CQRS file separation over a shared layer with annotations, and a separate Mailpit (MIT license) node for email OTPs.
After this PR, we can continue to add things like polish, more testing, and additional service implementations like for SMS for OTPs or ABAC validations for things like Device Fingerprints. I will also begin my work on the login/auth feature next.
Detailed Summary