Skip to content

Conversation

@DeathGun44
Copy link
Contributor

Description

This PR refactors GlobalConfigurationHelper.java to fix a fragility issue where adding new global configurations to the database causes the integration test suite to crash with IndexOutOfBoundsException.

Changes:

  • Map-Based Lookup: Replaced the fragile index-based iteration (parallel lists) with a robust Map-based lookup using configuration names. This prevents crashes when the database configuration count differs from the test harness default count.
  • Strict Validation: Implemented a strict check that throws a descriptive RuntimeException if a database configuration is missing from the test defaults. This prevents silent bypasses and directs developers to explicitly register new configurations to ensure test isolation.
  • Preserved Logic: Configuration reset logic (restoring values/enabled flags) remains behaviorally identical but is now order-independent and crash-proof.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per our guidelines
  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • Create/update unit or integration tests for verifying the changes made.
  • Follow our coding conventions.
  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@DeathGun44 DeathGun44 changed the title FINERACT-2450: Fix IndexOutOfBoundsException in GlobalConfigurationHelper.java FINERACT-2450: Fix IndexOutOfBoundsException in GlobalConfigurationHelper Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant