[FLINK-40303][table] Skip non-key NOT NULL checks for key-only deletes - #28883
Open
Au-Miner wants to merge 2 commits into
Open
[FLINK-40303][table] Skip non-key NOT NULL checks for key-only deletes#28883Au-Miner wants to merge 2 commits into
Au-Miner wants to merge 2 commits into
Conversation
Collaborator
…s sink AI-Contributed/Feature: 0/46 AI-Contributed/UT: 0/30
AI-Contributed/Feature: 0/0 AI-Contributed/UT: 0/2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Key-only DELETE records set non-key fields to null. When a sink declares NOT NULL constraints on non-key columns, the constraint enforcer incorrectly rejects these valid DELETE records.
Brief change log
CommonExecSinktoConstraintEnforcerExecutor.NotNullConstraintto skip non-key fields for key-only DELETE records while continuing to validate primary key fields.Verifying this change
Added
INSERT_SELECT_DELETE_BY_KEY_DELETE_BY_KEY_WITH_NOT_NULL_SINKtoDeletesByKeySemanticTests. The test covers a key-only source and sink, verifies that ChangelogNormalize can remain eliminated, and expects-D[1, null]to be accepted by a sink whose non-key column is NOT NULL.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation