[FLINK-40304][table] Fix PTF partition columns for multiple table arguments - #28884
Open
Au-Miner wants to merge 2 commits into
Open
[FLINK-40304][table] Fix PTF partition columns for multiple table arguments#28884Au-Miner wants to merge 2 commits into
Au-Miner wants to merge 2 commits into
Conversation
Collaborator
…uments AI-Contributed/Feature: 0/2 AI-Contributed/UT: 0/48
AI-Contributed/Feature: 0/0 AI-Contributed/UT: 0/6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This change fixes incorrect partition-column positions inferred for a PTF with multiple table arguments. The bug can omit an upsert key from a later table argument and prevent a valid query from being planned for an upsert sink.
Brief change log
StreamPhysicalProcessTableFunction#toPartitionColumnsto account for the cumulative output offset when deriving partition columns.Verifying this change
Added
ProcessTableFunctionTest#testUpsertKeyWithMultipleTableArgsto verify that the partition column of the second table argument remains a valid upsert key. The targeted regression test and the completeProcessTableFunctionTestsuite with 69 tests passed.Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation