Skip to content

[test] chore: fix flaky RemoteLogScannerITCase #3002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fresh-borzoni wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[test] chore: fix flaky RemoteLogScannerITCase #3002

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 28 additions & 26 deletions ...lient/src/test/java/org/apache/fluss/client/table/scanner/log/RemoteLogScannerITCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,50 +149,52 @@ void testScanFromRemoteAndProject(String format) throws Exception {

FLUSS_CLUSTER_EXTENSION.waitUntilSomeLogSegmentsCopyToRemote(new TableBucket(tableId, 0));

// test fetch.
// Build expected projected rows for [a, c].
List<GenericRow> expectedRowsAC = new ArrayList<>();
for (int i = 0; i < expectedSize; i++) {
String value = i % 2 == 0 ? "hello, friend" + i : null;
expectedRowsAC.add(row(i, value));
}

// test fetch with projection [a, c].
// Records may arrive out of order when spanning multiple remote log segments,
// so use containsExactlyInAnyOrderElementsOf instead of sequential assertions.
LogScanner logScanner = createLogScanner(table, new int[] {0, 2});
logScanner.subscribeFromBeginning(0);
int count = 0;
while (count < expectedSize) {
List<GenericRow> rowList = new ArrayList<>();
while (rowList.size() < expectedSize) {
ScanRecords scanRecords = logScanner.poll(Duration.ofSeconds(1));
for (ScanRecord scanRecord : scanRecords) {
assertThat(scanRecord.getChangeType()).isEqualTo(ChangeType.APPEND_ONLY);
assertThat(scanRecord.getRow().getFieldCount()).isEqualTo(2);
assertThat(scanRecord.getRow().getInt(0)).isEqualTo(count);
if (count % 2 == 0) {
assertThat(scanRecord.getRow().getString(1).toString())
.isEqualTo("hello, friend" + count);
} else {
// check null values
assertThat(scanRecord.getRow().isNullAt(1)).isTrue();
}
count++;
InternalRow row = scanRecord.getRow();
rowList.add(row(row.getInt(0), row.isNullAt(1) ? null : row.getString(1)));
}
}
assertThat(count).isEqualTo(expectedSize);
assertThat(rowList).containsExactlyInAnyOrderElementsOf(expectedRowsAC);
logScanner.close();

// fetch data with projection reorder.
// Build expected projected rows for [c, a] (reordered).
List<GenericRow> expectedRowsCA = new ArrayList<>();
for (int i = 0; i < expectedSize; i++) {
String value = i % 2 == 0 ? "hello, friend" + i : null;
expectedRowsCA.add(row(value, i));
}

// fetch data with projection reorder [c, a].
logScanner = createLogScanner(table, new int[] {2, 0});
logScanner.subscribeFromBeginning(0);
count = 0;
while (count < expectedSize) {
rowList = new ArrayList<>();
while (rowList.size() < expectedSize) {
ScanRecords scanRecords = logScanner.poll(Duration.ofSeconds(1));
for (ScanRecord scanRecord : scanRecords) {
assertThat(scanRecord.getChangeType()).isEqualTo(ChangeType.APPEND_ONLY);
assertThat(scanRecord.getRow().getFieldCount()).isEqualTo(2);
assertThat(scanRecord.getRow().getInt(1)).isEqualTo(count);
if (count % 2 == 0) {
assertThat(scanRecord.getRow().getString(0).toString())
.isEqualTo("hello, friend" + count);
} else {
// check null values
assertThat(scanRecord.getRow().isNullAt(0)).isTrue();
}
count++;
InternalRow row = scanRecord.getRow();
rowList.add(row(row.isNullAt(0) ? null : row.getString(0), row.getInt(1)));
}
}
assertThat(count).isEqualTo(expectedSize);
assertThat(rowList).containsExactlyInAnyOrderElementsOf(expectedRowsCA);
logScanner.close();
}

Expand Down
Loading