Skip to content

[spark] support scala 2.13#3041

Open
YannByron wants to merge 1 commit intoapache:mainfrom
YannByron:main-scala213
Open

[spark] support scala 2.13#3041
YannByron wants to merge 1 commit intoapache:mainfrom
YannByron:main-scala213

Conversation

@YannByron
Copy link
Copy Markdown
Contributor

@YannByron YannByron commented Apr 9, 2026

Purpose

Linked issue: close #2667

Brief change log

Tests

API and Format

Documentation

@YannByron
Copy link
Copy Markdown
Contributor Author

YannByron commented Apr 9, 2026

@wuchong @Yohahaha please take a look, thanks.

@beryllw
Copy link
Copy Markdown
Contributor

beryllw commented Apr 11, 2026

LGTM, thanks for your contribution!

@wuchong cc

fresh-borzoni
fresh-borzoni approved these changes Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@fresh-borzoni fresh-borzoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YannByron TY for the PR, LGTM, one nit comment that we may wish to ignore.

We still import scala.collection.JavaConverters, it was deprecated in 2.13 in favor of scala.jdk.CollectionConverters.

@YannByron
Copy link
Copy Markdown
Contributor Author

YannByron commented Apr 14, 2026 •
edited
Loading

@YannByron TY for the PR, LGTM, one nit comment that we may wish to ignore.

We still import scala.collection.JavaConverters, it was deprecated in 2.13 in favor of scala.jdk.CollectionConverters.

Yes, although we can continue to use this deprecated scala.collection.JavaConverters, I do plan to replace them with scala.jdk.CollectionConverters, and at the same time I wanna introduce scalafix or anything else to prevent any subsequent code from using the old scala.collection.JavaConverters.

leonardBang
leonardBang reviewed Apr 14, 2026
View reviewed changes
.github/workflows/stage.sh
echo "-Pspark3 -pl fluss-test-coverage,$modules_spark3"
;;
(${STAGE_SPARK_SCALA213})
echo "-Pspark3,scala-2.13 -pl fluss-test-coverage,$modules_spark3"
Copy link
Copy Markdown
Contributor

@leonardBang leonardBang Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have <id>spark3</id> profile ?

Copy link
Copy Markdown
Contributor

@leonardBang leonardBang Apr 14, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need scala-2.13 as
https://github.com/apache/fluss/pull/3041/changes#diff-f3259c7c61a818942ee406ae16bc62d985f8f5b5c64fef3d1501d972b70ee03aR42 already have a scala file ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leonardBang leonardBang leonardBang left review comments

+2 more reviewers

@Yohahaha Yohahaha Yohahaha approved these changes

@fresh-borzoni fresh-borzoni fresh-borzoni approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[spark] to support scala2.13

5 participants

@YannByron @beryllw @leonardBang @Yohahaha @fresh-borzoni