[WIP][CORE] Pass Spark task attempt id and pool name from Java to native runtime/memory-manager#12376
Open
taiyang-li wants to merge 1 commit into
Open
[WIP][CORE] Pass Spark task attempt id and pool name from Java to native runtime/memory-manager#12376taiyang-li wants to merge 1 commit into
taiyang-li wants to merge 1 commit into
Conversation
…native runtime/memory-manager This patch extends RuntimeJniWrapper.createRuntime and the NativeMemoryManagerJniWrapper create/hold/release JNI methods with extra parameters that propagate the Spark task attempt id (and a memory-pool name) from the JVM down to the native side. The native Runtime and NativeMemoryManager just store the values and expose simple getters; no behavior change for existing Velox/CH backends. This makes per-task diagnostics and per-pool logging possible, and unblocks future backends (e.g. Bolt) that need task-level identification at the native layer. Generated-by: Claude claude-sonnet-4-6 Co-Authored-By: Aime <aime@bytedance.com> Change-Id: Iff1124ec0e8946f46dbbed096f9197ff45c9f433
taiyang-li
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch extends the JNI bridge between the Java/Scala layer and the native C++ layer to propagate Spark task-level identification information:
long taskAttemptIdparameterString name(pool name) parameterString nameandlong taskAttemptIdparameterslong taskAttemptIdparameterOn the native C++ side:
Runtimegains ataskAttemptId_member with getter/setterMemoryManagergains aname_member with getter/setterThe values are set via setters after object creation, so no changes are needed for existing backend subclasses (Velox, ClickHouse). The Factory typedefs and constructor signatures remain unchanged.
This makes per-task diagnostics and per-pool logging possible, and unblocks future backends (e.g. Bolt) that need task-level identification at the native layer.
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
Generated-by: Claude claude-sonnet-4-6