[VL] Validate cuDF whole stage even when GPU table scan is enabled#12383
Open
ReemaAlzaid wants to merge 1 commit into
Open
[VL] Validate cuDF whole stage even when GPU table scan is enabled#12383ReemaAlzaid wants to merge 1 commit into
ReemaAlzaid wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
CudfNodeValidationRuledecides which whole stage transformers can run on the cuDF/GPU backend. That tag is used for stage level GPU offload, GPU shuffle, and node naming.Before this change, when
spark.gluten.sql.columnar.backend.velox.cudf.enableTableScan=true, we were tagging every stage for GPU offload without running native validation, even whenspark.gluten.sql.columnar.backend.velox.cudf.enableValidation=true. That was different from theenableTableScan=falsepath, where validation is still applied.This PR makes the validation behavior consistent. We now validate the stage regardless of
enableTableScan. The native validator already handlesTableScan, so stages with scans can still offload, but only if the rest of the operators are supported by cuDF.I also moved the decision logic into a small
decideOffload(...)helper so it can be unit tested without needing a GPU. No new configs are added.How was this patch tested?
CudfNodeValidationRuleSuite, with 4 passing tests covering the offload decision matrix.enableTableScan=truewhere a cuDF-unsupported stage should not be force-offloaded.cudf=trueandenableTableScan=true. Supported stages keep the same behavior