[GLUTEN-12313][VL] followup to cleanup CI image#12384
Open
zhouyuan wants to merge 5 commits into
Open
Conversation
Signed-off-by: Yuan <yuanzhou@apache.org>
This reverts commit c3d0cdb.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Gluten’s CI/Docker image build setup by removing some no-longer-used Docker image build jobs and adjusting how CMake is provisioned in CentOS-based build environments (notably for vcpkg images).
Changes:
- Remove Docker image build jobs for
vcpkg-centos-7andvcpkg-centos-8, and update the manifest-merge job accordingly. - Update CentOS 9 static-build image to install CMake via the OS package manager instead of pip.
- Update CentOS 8 GCC13 static-build image to install a specific Kitware CMake release via the
.shinstaller, and remove pip-based CMake install from the CentOS 8/9 vcpkg dependency setup script.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| dev/vcpkg/setup-build-depends.sh | Removes pip-pinned CMake install for CentOS 8/9 dependency setup. |
| dev/docker/Dockerfile.centos9-static-build | Switches CMake provisioning from pip-pinned to distro cmake package. |
| dev/docker/Dockerfile.centos8-gcc13-static-build | Switches to installing a pinned Kitware CMake .sh installer. |
| .github/workflows/docker_image.yml | Removes unused image build jobs and updates digest/manifest merge to match. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -157,9 +157,6 @@ install_centos_8() { | |||
|
|
|||
| pip3 install --upgrade pip | |||
| yum update -y && yum install -y epel-release sudo dnf && yum install -y ccache; \ | ||
| dnf install -y --setopt=install_weak_deps=False gcc-toolset-12 gcc-toolset-13 perl-FindBin; \ | ||
| pip install cmake==3.31.4; \ | ||
| dnf install -y --setopt=install_weak_deps=False gcc-toolset-12 gcc-toolset-13 perl-FindBin cmake; \ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This patch removed the unused docker images. Also fixed the cmake issue in vcpkg-centos-8/9 image
How was this patch tested?
manually verified
Was this patch authored or co-authored using generative AI tooling?
Related issue: #12313