8.x Register CriteriaTypeCheckingExtension and cover createCriteria().<terminal>{} closures

[codeconsole]

What

CriteriaTypeCheckingExtension exists in grails-core but is not registered in @GrailsCompileStatic's extension list, and isCriteriaCall only recognizes the Domain.withCriteria { … } / Domain.createCriteria() forms (closure as the direct argument). The chained Domain.createCriteria().<terminal> { … } form — where the closure is the argument to a terminal called on the builder — is never matched, so a criteria scope is never opened for it.

Why it matters

Most chained terminals (list, listDistinct, get, scroll) still type-check today because BuildableCriteria declares them with a Closure parameter and @DelegatesTo resolves the closure body. But count(Closure) is not declared on BuildableCriteria, so:

@GrailsCompileStatic
class Foo {
    def c() { Person.createCriteria().count { eq 'name', 'Anakin' } }
}

fails static compilation on stock 8.0.x:

[Static type checking] - Cannot find matching method
org.grails.datastore.mapping.query.api.BuildableCriteria#count(groovy.lang.Closure)

forcing a @CompileDynamic escape hatch.

Change

1. Extend isCriteriaCall to also open a criteria scope when the call is a terminal (list, listDistinct, get, count, scroll) chained directly on Domain.createCriteria(). Registration alone is not enough — the createCriteria() scope is exited (via afterMethodCall) before the terminal call is visited, so the terminal needs to be recognized in its own right.
2. Add org.grails.compiler.CriteriaTypeCheckingExtension to the @CompileStatic(extensions=[…]) list on @GrailsCompileStatic.

Test

Adds 'Test compiling a class which invokes a chained createCriteria() terminal on a domain class' to GrailsCompileStaticCompilationErrorsSpec, covering all six chained terminals. It fails on stock 8.0.x (on the count terminal) and passes with this change. The existing GRAILS-11255 criteria spec continues to pass.

Scope / limits

The extension makes the direct children of the criteria closure dynamic. Deeply nested builder closures (e.g. projections { property '…' }) and post-processing that indexes the result (withCriteria { … }[0]) still require @CompileDynamic — out of scope here.

[codecov]

Codecov Report

❌ Patch coverage is 84.61538% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.3627%. Comparing base (41f9fb9) to head (b10f36f).
⚠️ Report is 68 commits behind head on 8.0.x.

Files with missing lines	Patch %	Lines
...ails/compiler/CriteriaTypeCheckingExtension.groovy	0.0000%	14 Missing ⚠️

Additional details and impacted files

@@                Coverage Diff                 @@
##                8.0.x     #15720        +/-   ##
==================================================
+ Coverage     48.3483%   48.3627%   +0.0144%     
- Complexity      15104      15233       +129     
==================================================
  Files            1870       1877         +7     
  Lines           85459      85905       +446     
  Branches        14901      14974        +73     
==================================================
+ Hits            41318      41546       +228     
- Misses          37805      37986       +181     
- Partials         6336       6373        +37     

Files with missing lines	Coverage Δ
...g/tck/support/StaticCompiledCriteriaQueries.groovy	100.0000% <100.0000%> (ø)
...esting/tck/tests/StaticCompiledCriteriaSpec.groovy	100.0000% <100.0000%> (ø)
...ails/compiler/CriteriaTypeCheckingExtension.groovy	0.0000% <0.0000%> (ø)

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jdaugherty]

To change the default, we need to expand the test coverage so that there are tests in the TCK - this way we know we haven't broken it in hibernate 7.

[codeconsole]

Added in b10f36f. The TCK now executes criteria queries that were compiled with @GrailsCompileStatic, covering both dispatch paths the extension produces: statically-resolved Criteria API calls and the dynamic fallback (projections, min/countDistinct/property, maxResults, and the chained count { } terminal, which is not declared on BuildableCriteria). Verified green against the in-memory, Hibernate 5, Hibernate 7, and MongoDB implementations locally.

[bito-code-review]

The pull request already includes a new test case, 'Test compiling a class which invokes a chained createCriteria() terminal on a domain class', within GrailsCompileStaticCompilationErrorsSpec.groovy. This test verifies that chained createCriteria() calls (e.g., .list, .get, .count) are correctly type-checked under @GrailsCompileStatic. If further TCK (Technology Compatibility Kit) coverage is required, you should add similar integration tests to the dedicated TCK test suite modules, as the current tests are located in the grails-test-suite-uber module.

grails-test-suite-uber/src/test/groovy/grails/compiler/GrailsCompileStaticCompilationErrorsSpec.groovy

void 'Test compiling a class which invokes a chained createCriteria() terminal on a domain class'() {
        given:
        def gcl = new GroovyClassLoader()

        when: 'the criteria builder closure is the argument to a terminal chained directly on createCriteria()'
        def c = gcl.parseClass('''
            package grails.compiler

            @GrailsCompileStatic
            class SomeClass {

                def someMethod() {
                    Person.createCriteria().list {
                        cache true
                        eq 'name', 'Anakin'
                    }
                    // ... other terminals
                }
            }
        '''.stripIndent())

        then: 'no errors are thrown'
        c
    }

[testlens-app]

✅ All tests passed ✅

⚠️ TestLens detected flakiness ⚠️

Test Summary

Check	Project/Task	Test	Runs
CI / Functional Tests (Java 21, indy=false)	:grails-test-examples-scaffolding:integrationTest	UserControllerSpec > User list	❌ ✅

🏷️ Commit: b10f36f
▶️ Tests: 5719 executed
⚪️ Checks: 43/43 completed

---

Learn more about TestLens at testlens.app.