Add GSP Layout (SiteMesh) option dropdown#118
Closed
codeconsole wants to merge 0 commit into
Closed
Conversation
Contributor
|
Appreciate the effort 👍 However, I'm not sure the GSP layout engine should have such a prominent position in the Forge. Can't we just switch these around? (For reference, this is what the change in this PR looks like) |
Contributor
|
I disagree with this change. It's not like there are going to be multiple options for this longer term. We should leave it as a feature. |
codeconsole
force-pushed
the
feat/gsp-layout-option
branch
from
b335c81 to
e73ca1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a "GSP Layout" radio group (SiteMesh 3 default / SiteMesh 2) driven by the new
gspLayoutselect option, and sendsgspLayouton the features/diff/preview/create requests plus the generated--gsp-layoutCLI arg.Pairs with the grails-forge backend change (apache/grails-core#15713), where
SiteMesh 3andGSP SiteMesh 2 Layoutsbecome invisible, option-driven defaults. Together they fix the UI glitch where selecting SiteMesh 2 left SiteMesh 3 still shown as an included default — the layout choice is now a single dropdown instead of two conflicting feature cards.Lint clean; vitest suite green (no snapshot changes).