Add Grails 8 HTTP client guide (v8 prose, snippets, guides.yml)#520
Merged
jamesfredley merged 3 commits intoJul 21, 2026
Merged
Conversation
sanjana2505006
force-pushed
the
grails-http-client-v8-guide
branch
from
June 26, 2026 21:05
7eae8b7 to
259905b
Compare
jamesfredley
left a comment
jamesfredley
left a comment
Contributor
There was a problem hiding this comment.
Line-level review of the guide content in this PR. The sample app itself (snippets' source) is being reviewed separately on grails-guides/grails-http-client#1, and the grails8 branch / grails-guides/grails-http-client repo referenced by sampleRef now exist, so git clone -b grails8 ... resolves. Comments below are scoped to the .adoc prose in this PR.
Contributor
Author
|
@jamesfredley i just updated this pr, please have a look and let me know if there's any scope for improvements |
Guide under guides/grails-http-client/v8 with vendored snippets. Registers grails-http-client in conf/guides.yml. Addresses review feedback on prose, paths, and wording. Sample app: grails-guides/grails-http-client (grails8).
sanjana2505006
force-pushed
the
grails-http-client-v8-guide
branch
from
July 18, 2026 17:16
3ba72c2 to
af139cd
Compare
Document the required HTTP-service configuration, mirror the working MockWebServer coverage, and keep long source captions within mobile guide pages. Co-authored-by: Sanjana <sanju250506@gmail.com>
jamesfredley
approved these changes
Jul 21, 2026
jamesfredley
left a comment
jamesfredley
left a comment
Contributor
There was a problem hiding this comment.
Validated against the merged Grails 8 sample app. Guide schema and render are green, snippets match the tested sample, live desktop/mobile QA passes, and the final diff passed Oracle plus Codex review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.