GROOVY-12089: Groovy 5 ClassNode.getGetterMethod() can clone a getter…

[paulk-asert]

… with a null exceptions array when @entity and @Sortable are combined

[testlens-app]

🚨 TestLens detected 4 failed tests 🚨

Here is what you can do:

1. Inspect the test failures carefully.
2. If you are convinced that some of the tests are flaky, you can mute them below.
3. Finally, trigger a rerun by checking the rerun checkbox.

Test Summary

Check	Project/Task	Test	Runs
Build and test / lts (17, windows-latest, 1)	:test	GenericsSTCTest > testReturnTypeInferenceWithMethodGenerics18()	❌
Build and test / lts (17, windows-latest, 1)	:test	GenericsSTCTest > testReturnTypeInferenceWithMethodGenerics18a()	❌
Build and test / lts (17, windows-latest, 1)	:test	GenericsStaticCompileTest > testReturnTypeInferenceWithMethodGenerics18()	❌
Build and test / lts (17, windows-latest, 1)	:test	GenericsStaticCompileTest > testReturnTypeInferenceWithMethodGenerics18a()	❌

🏷️ Commit: 62805bc
▶️ Tests: 101251 executed
⚪️ Checks: 30/30 completed

Test Failures

GenericsSTCTest > testReturnTypeInferenceWithMethodGenerics18() (:test in Build and test / lts (17, windows-latest, 1))

org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed:
TestScriptea21fcc7572f40578dae33eb42be4157.groovy: 5: unable to resolve class ListMultimap<java.lang.String, java.lang.Integer>
 @ line 5, column 43.
               ListMultimap<String, Integer> mmap = ArrayListMultimap.create()
                                             ^

1 error

	at org.codehaus.groovy.control.ErrorCollector.failIfErrors(ErrorCollector.java:333)
	at org.codehaus.groovy.control.CompilationUnit$ISourceUnitOperation.doPhaseOperation(CompilationUnit.java:989)
	at org.codehaus.groovy.control.CompilationUnit.processPhaseOperations(CompilationUnit.java:749)
	at org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:723)
	at groovy.lang.GroovyClassLoader.doParseClass(GroovyClassLoader.java:423)
	at groovy.lang.GroovyClassLoader.lambda$parseClass$3(GroovyClassLoader.java:364)
	at org.codehaus.groovy.runtime.memoize.ConcurrentCommonCache.getAndPut(ConcurrentCommonCache.java:143)
	at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.java:364)
	at groovy.lang.GroovyShell.parseClass(GroovyShell.java:665)
	at groovy.lang.GroovyShell.parse(GroovyShell.java:678)
	at groovy.lang.GroovyShell.parse(GroovyShell.java:690)
	at groovy.lang.GroovyShell.evaluate(GroovyShell.java:552)
	at groovy.lang.GroovyShell.evaluate(GroovyShell.java:588)
	at groovy.lang.GroovyShell.evaluate(GroovyShell.java:572)
	at groovy.transform.stc.StaticTypeCheckingTestCase.assertScript(StaticTypeCheckingTestCase.groovy:78)
	at groovy.transform.stc.GenericsSTCTest.testReturnTypeInferenceWithMethodGenerics18(GenericsSTCTest.groovy:701)

GenericsSTCTest > testReturnTypeInferenceWithMethodGenerics18a() (:test in Build and test / lts (17, windows-latest, 1))

org.opentest4j.AssertionFailedError: Not all expected error messages were found, compiler threw these errors : org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed:
TestScript4b83448a574542aa8c1df7372cd71ba3.groovy: 5: unable to resolve class ListMultimap<java.lang.String, java.lang.Integer>
 @ line 5, column 24.
               def mmap = (ListMultimap<String, Integer>) ArrayListMultimap.create()
                          ^

1 error

	at org.junit.jupiter.api.Assertions.fail(Assertions.java:142)
	at groovy.transform.stc.StaticTypeCheckingTestCase.shouldFailWithMessages(StaticTypeCheckingTestCase.groovy:95)
	at groovy.transform.stc.GenericsSTCTest.testReturnTypeInferenceWithMethodGenerics18a(GenericsSTCTest.groovy:719)

GenericsStaticCompileTest > testReturnTypeInferenceWithMethodGenerics18() (:test in Build and test / lts (17, windows-latest, 1))

org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed:
TestScript86cc54d0a9dd4586a68f44dd10049965.groovy: 5: unable to resolve class ListMultimap<java.lang.String, java.lang.Integer>
 @ line 5, column 43.
               ListMultimap<String, Integer> mmap = ArrayListMultimap.create()
                                             ^

1 error

	at org.codehaus.groovy.control.ErrorCollector.failIfErrors(ErrorCollector.java:333)
	at org.codehaus.groovy.control.CompilationUnit$ISourceUnitOperation.doPhaseOperation(CompilationUnit.java:989)
	at org.codehaus.groovy.control.CompilationUnit.processPhaseOperations(CompilationUnit.java:749)
	at org.codehaus.groovy.control.CompilationUnit.compile(CompilationUnit.java:723)
	at groovy.lang.GroovyClassLoader.doParseClass(GroovyClassLoader.java:423)
	at groovy.lang.GroovyClassLoader.lambda$parseClass$3(GroovyClassLoader.java:364)
	at org.codehaus.groovy.runtime.memoize.ConcurrentCommonCache.getAndPut(ConcurrentCommonCache.java:143)
	at groovy.lang.GroovyClassLoader.parseClass(GroovyClassLoader.java:364)
	at groovy.lang.GroovyShell.parseClass(GroovyShell.java:665)
	at groovy.lang.GroovyShell.parse(GroovyShell.java:678)
	at groovy.lang.GroovyShell.parse(GroovyShell.java:690)
	at groovy.lang.GroovyShell.evaluate(GroovyShell.java:552)
	at groovy.lang.GroovyShell.evaluate(GroovyShell.java:588)
	at groovy.lang.GroovyShell.evaluate(GroovyShell.java:572)
	at groovy.transform.stc.StaticTypeCheckingTestCase.assertScript(StaticTypeCheckingTestCase.groovy:78)
	at groovy.transform.stc.GenericsSTCTest.testReturnTypeInferenceWithMethodGenerics18(GenericsSTCTest.groovy:701)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

GenericsStaticCompileTest > testReturnTypeInferenceWithMethodGenerics18a() (:test in Build and test / lts (17, windows-latest, 1))

org.opentest4j.AssertionFailedError: Not all expected error messages were found, compiler threw these errors : org.codehaus.groovy.control.MultipleCompilationErrorsException: startup failed:
TestScript22784e3714f04aa9a29272e4613a12dd.groovy: 5: unable to resolve class ListMultimap<java.lang.String, java.lang.Integer>
 @ line 5, column 24.
               def mmap = (ListMultimap<String, Integer>) ArrayListMultimap.create()
                          ^

1 error

	at groovy.transform.stc.StaticTypeCheckingTestCase.shouldFailWithMessages(StaticTypeCheckingTestCase.groovy:95)
	at groovy.transform.stc.GenericsSTCTest.testReturnTypeInferenceWithMethodGenerics18a(GenericsSTCTest.groovy:719)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

Muted Tests

Select tests to mute in this pull request:

• GenericsSTCTest > testReturnTypeInferenceWithMethodGenerics18()
• GenericsSTCTest > testReturnTypeInferenceWithMethodGenerics18a()
• GenericsStaticCompileTest > testReturnTypeInferenceWithMethodGenerics18()
• GenericsStaticCompileTest > testReturnTypeInferenceWithMethodGenerics18a()

Reuse successful test results:

• ♻️ Only rerun the tests that failed or were muted before

Click the checkbox to trigger a rerun:

• Rerun jobs

---

Learn more about TestLens at testlens.app.

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.4577%. Comparing base (7200290) to head (62805bc).

Additional details and impacted files

@@                Coverage Diff                 @@
##               master      #2611        +/-   ##
==================================================
+ Coverage     68.4522%   68.4577%   +0.0055%     
- Complexity      33503      33504         +1     
==================================================
  Files            1518       1518                
  Lines          127096     127096                
  Branches        23062      23063         +1     
==================================================
+ Hits            87000      87007         +7     
+ Misses          32372      32365         -7     
  Partials         7724       7724                

Files with missing lines	Coverage Δ
.../main/java/org/codehaus/groovy/ast/MethodNode.java	97.9381% <100.0000%> (ø)

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.