GUACAMOLE-827 : Fix BlobWriter race condition in chunk upload#1194
Open
GokulRG wants to merge 1 commit intoapache:mainfrom
Open
GUACAMOLE-827 : Fix BlobWriter race condition in chunk upload#1194GokulRG wants to merge 1 commit intoapache:mainfrom
GokulRG wants to merge 1 commit intoapache:mainfrom
Conversation
Author
|
This MR should address this longstanding bug where subsequent chunks are sent to the BlobWriter before the previous chunk is fully processed resulting in incomplete file transfers with missing chunks. |
Contributor
|
@GokulRG Thanks for submitting this. Please fix the style of the PR title and the commit message by adding a ":" after |
Author
Of course. Thank you! |
Author
|
Hi @necouchman, Were you able to look at this MR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a critical race condition where multiple blob chunks could be read and sent simultaneously without proper ACK synchronization.
Changes: