GUACAMOLE-1993: Provide built manual as github artifact as part of PR build.#262
Open
jmuehlner wants to merge 1 commit intoapache:mainfrom
Open
GUACAMOLE-1993: Provide built manual as github artifact as part of PR build.#262jmuehlner wants to merge 1 commit intoapache:mainfrom
jmuehlner wants to merge 1 commit intoapache:mainfrom
Conversation
mike-jumper
approved these changes
Mar 20, 2025
Contributor
mike-jumper
left a comment
mike-jumper
left a comment
There was a problem hiding this comment.
LGTM - I'm going to close and reopen to trigger this and check out the resulting artifact.
Contributor
|
That works quite nicely. |
mike-jumper
requested changes
Mar 20, 2025
Comment on lines
+29
to
+33
| docker build --pull --no-cache --tag built-manual-image . | ||
| docker create --name built-manual-container built-manual-image | ||
| docker cp built-manual-container:/usr/local/apache2/htdocs "$RUNNER_TEMP/htdocs" | ||
| docker container rm --force --volumes built-manual-container | ||
| docker image rm --force built-manual-image |
Contributor
There was a problem hiding this comment.
Just occurred to me that this will be a race condition if multiple PR builds end up getting assigned to the same runner. Maybe the container name and image should be unique for the PR?
mike-jumper
reviewed
Mar 20, 2025
Comment on lines
+30
to
+32
| docker create --name built-manual-container built-manual-image | ||
| docker cp built-manual-container:/usr/local/apache2/htdocs "$RUNNER_TEMP/htdocs" | ||
| docker container rm --force --volumes built-manual-container |
Contributor
There was a problem hiding this comment.
I think you can avoid keeping the temporary container across multiple commands by replacing this with something like:
docker run --rm built-manual-image tar -C /usr/local/apache2 -c htdocs | tar -C "$RUNNER_TEMP" -x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.