Skip to content

HIVE-29555: [HPLSQL]Errorcode handling is not proper in HPLSQL. #6422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdayakar wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −0
Open

HIVE-29555: [HPLSQL]Errorcode handling is not proper in HPLSQL. #6422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions hplsql/src/main/java/org/apache/hive/hplsql/Stmt.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1061,6 +1061,7 @@ public Integer exec(HplsqlParser.Exec_stmtContext ctx) {
exec.signal(query);
return 1;
}
exec.setSqlSuccess();
try {
if (ctx.T_INTO() != null) {
int cols = ctx.L_ID().size();
Expand Down
13 changes: 13 additions & 0 deletions itests/hive-unit/src/test/java/org/apache/hive/beeline/TestHplSqlViaBeeLine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1419,6 +1419,19 @@ public void testQuit() throws Throwable {
OutStream.ERR);
}

@Test
public void testERRORCODEForExecuteStatements() throws Throwable {
String scriptText =
"SET hplsql.onerror='seterror';\n" +
"CREATE TABLE result (id bigint, name string);\n" +
"EXECUTE IMMEDIATE 'load data local inpath ''../../data/files/hplsql.txt'' OVERWRITE INTO table result';\n" +
Copy link
Copy Markdown
Contributor

@kasakrisz kasakrisz Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary to actually load the data?

How about testing with statements like

select 1;

and

select 1/0;

"EXECUTE 'select * from unknown';\n" +
"PRINT 'First ERRORCODE: ' || errorcode\n" +
"EXECUTE 'select * from result';\n" +
"PRINT 'Second ERRORCODE: ' || errorcode";
testScriptFile(scriptText, args(), "First ERRORCODE: -1.*Second ERRORCODE: 0", OutStream.ERR);
}

private static List<String> args() {
return Arrays.asList("-d", BeeLine.BEELINE_DEFAULT_JDBC_DRIVER,
"-u", miniHS2.getBaseJdbcURL() + ";mode=hplsql", "-n", USER_NAME);
Expand Down
Loading