[WIP] HIVE-29563: Iceberg REST Catalog's error logs are too verbose#6425
Draft
okumin wants to merge 2 commits intoapache:masterfrom
Draft
[WIP] HIVE-29563: Iceberg REST Catalog's error logs are too verbose#6425okumin wants to merge 2 commits intoapache:masterfrom
okumin wants to merge 2 commits intoapache:masterfrom
Conversation
asf-ci-hive
added
tests pending
tests unstable
and removed
tests pending
tests unstable
labels
okumin
force-pushed
the
HIVE-29563-rest-logging
branch
from
9debb2e to
1daa058
Compare
asf-ci-hive
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
okumin
commented
Apr 14, 2026
| // The caller is responsible for closing the underlying catalog backing this REST catalog. | ||
| response.setStatus(error.code()); | ||
| RESTObjectMapper.mapper().writeValue(response.getWriter(), error); | ||
| return null; |
Contributor
Author
There was a problem hiding this comment.
RESTServerCatalogAdapter on apache/iceberg extends a RESTClient. I don't know the exact reason. The trick is used in some integration tests.
Anyway, as our adapter never behaves as a client, I removed the dependency on RESTClient. As a good side effect, this change ensures only a single path invokes RESTServerCatalogAdapter#execute and allows us to simplify the implementation.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Stop logging every client-side error, i.e., 40x errors.
https://issues.apache.org/jira/browse/HIVE-29563
Why are the changes needed?
As explained in HIVE-29563, the current REST API prints the entire stack trace on every error.
apache/iceberg has the same problem and sent a patch, but it has not been reviewed: apache/iceberg#14908
Does this PR introduce any user-facing change?
It includes a change for HMS administrators.
How was this patch tested?