Skip to content

Improve ExecProcess Lombok accessors and unit tests#7565

Merged
hansva merged 1 commit into
apache:mainfrom
leehaut:hotfix/lance-common-99
Jul 20, 2026
Merged

Improve ExecProcess Lombok accessors and unit tests#7565
hansva merged 1 commit into
apache:mainfrom
leehaut:hotfix/lance-common-99

Conversation

@leehaut

@leehaut leehaut commented Jul 18, 2026

Copy link
Copy Markdown
Contributor
  • Replace hand-written getters/setters in ExecProcessMeta, EPField, and ProcessResult with Lombok @Getter/@Setter
  • Rename ProcessResult exit-status accessors from the misleading ExistStatus names to getExitValue() / setExitValue(), and update ExecProcess accordingly
  • Expand unit tests for ExecProcessMeta, and add ProcessResultTest plus ExecProcessDataTest

Signed-off-by: lance <leehaut@gmail.com>
@hansva
hansva merged commit 44bfa90 into apache:main Jul 20, 2026
2 of 3 checks passed
mattcasters added a commit that referenced this pull request Jul 20, 2026
… exec (#7584)

* issue #7582 : fix IT write permissions and ExecProcess single-command exec

Harden integration-test Docker prep so project output/, files/, and roots
are writable under the container UID, and move generated spreadsheet/MDI/
parquet/http artifacts into world-writable output/ paths (with golden data
and gitignore updates). Also restore Runtime.exec(String) for ExecProcess
single-command mode so command lines are tokenized again (#7565 regression).

* issue #7582 : adopt StringTokenizer-based ExecProcess fix from #7581

Use explicit whitespace tokenization before Runtime.exec(String[]) for
single-command mode (avoids the deprecated String overload), and add a
unit test for tokenizeCommandLine. Credit: @leehaut in #7581.
mattcasters added a commit to hansva/hop that referenced this pull request Jul 20, 2026
Match historical Runtime.exec(String) whitespace tokenization via
StringTokenizer before exec(String[]), so single-command fields like
"/bin/echo hop-single" work again. Based on @leehaut's fix in apache#7581.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants