Skip to content

Slightly better and efficient #toHexString method #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ok2c merged 1 commit into from
Jun 11, 2025
Merged

Slightly better and efficient #toHexString method #526

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions httpcore5/src/main/java/org/apache/hc/core5/util/TextUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,17 +124,16 @@ public static boolean containsBlanks(final CharSequence s) {
*
* @since 5.0
*/
private static final char[] HEX_CHARS = { '0', '1', '2', '3', '4', '5', '6', '7', '8', '9', 'a', 'b', 'c', 'd',
'e', 'f' };

public static String toHexString(final byte[] bytes) {
if (bytes == null) {
return null;
}
final StringBuilder buffer = new StringBuilder(bytes.length * 2);
for (final byte element : bytes) {
final int unsignedB = element & 0xff;
if (unsignedB < 16) {
buffer.append('0');
}
buffer.append(Integer.toHexString(unsignedB));
for (final byte b : bytes) {
buffer.append(HEX_CHARS[(0xf0 & b) >>> 4]).append(HEX_CHARS[0x0f & b]);
}
return buffer.toString();
}
Expand Down