HTTPCLIENT-2398: break recursive pool callback chain#560
Closed
arturobernalg wants to merge 1 commit intoapache:masterfrom
Closed
HTTPCLIENT-2398: break recursive pool callback chain#560arturobernalg wants to merge 1 commit intoapache:masterfrom
arturobernalg wants to merge 1 commit intoapache:masterfrom
Conversation
Guard callback drain in Strict/Lax pools; avoid fireCallbacks()->release() re-entry. Prevents StackOverflowError under fast-fail connect/retry; no semantic change.
arturobernalg
force-pushed
the
HTTPCLIENT-2398
branch
from
502cadf to
dae1cb4
Compare
Member
|
@arturobernalg Please see my comment in https://issues.apache.org/jira/browse/HTTPCLIENT-2398 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix StackOverflowError from synchronous re-entrant callback dispatch in pools.
Add re-entrancy guard, factor releaseInternal, make drain iterative; mirror in LaxConnPool.
Preserves synchronous semantics; completions still drained inline.
Add regression tests: pre-fix overflows; post-fix iterates to high counts.