Add per-session cap for queued reactor commands#590
Closed
arturobernalg wants to merge 1 commit intoapache:masterfrom
Closed
Add per-session cap for queued reactor commands#590arturobernalg wants to merge 1 commit intoapache:masterfrom
arturobernalg wants to merge 1 commit intoapache:masterfrom
Conversation
Enforce limit in IOSessionImpl and cover with a regression test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds an optional cap on the number of queued commands per I/O session. When configured, IOSessionImpl rejects additional enqueues once the per-session queue reaches the limit and releases capacity as commands are polled. The default remains unchanged (unlimited) when the option is not set. A small regression test covers rejection and subsequent acceptance once the queue is drained.