Fix SOCKS handshake to fail on EOF.#604
Merged
arturobernalg merged 1 commit intoapache:masterfrom Jan 22, 2026
Merged
Conversation
Treat ByteChannel.read() returning -1 as connection closed and abort the SOCKS protocol state machine instead of spinning and leaving session requests pending.
Member
Author
@ok2c Do you want me to wait to the original reporter test the fix? |
Member
|
@arturobernalg If you are no longer able to reproduce the issue with the test app posted by the reporter, just merge the fix, cherry-pick it to |
arturobernalg
added a commit
that referenced
this pull request
Jan 22, 2026
Treat ByteChannel.read() returning -1 as connection closed and abort the SOCKS protocol state machine instead of spinning and leaving session requests pending. (cherry picked from commit ce8f8bc)
Member
Author
Done. on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Treat ByteChannel.read() returning -1 as connection closed and abort the SOCKS protocol state machine instead of spinning and leaving session requests pending.