Conversation
wgtmac
requested changes
Jan 19, 2026
HuaHuaY
reviewed
Jan 19, 2026
zhjwpku
force-pushed
the
add_fast_append
branch
from
869196d to
7cfc0e9
Compare
Change DataFileSet from std::unordered_set to a custom class that preserves insertion order, similar to Java's DataFileSet which uses LinkedHashSet. This is important for row ID assignment in v3 manifests, where row IDs are assigned based on the order files are written. The implementation uses both a vector (for insertion order) and an unordered_set (for O(1) duplicate detection) to maintain the same API while preserving order.
wgtmac
reviewed
Jan 20, 2026
zhjwpku
force-pushed
the
add_fast_append
branch
from
5faf24c to
7118dcc
Compare
wgtmac
approved these changes
Jan 20, 2026
| #include "iceberg/result.h" | ||
| #include "iceberg/type_fwd.h" | ||
| #include "iceberg/update/snapshot_update.h" | ||
| #include "iceberg/util/content_file_util.h" |
Member
There was a problem hiding this comment.
nit: Consider moving DataFileSet out of content_file_util.h to avoid including more headers than needed. We may also need some test cases of it.
Collaborator
Author
There was a problem hiding this comment.
ok, do you mind if I do the refactor in a separate PR, along with some of the other TODOs we mentioned in this PR?
Member
There was a problem hiding this comment.
Yes, feel free to add them as followups.
Member
|
Thanks a lot for working on this! This completes the 0.2.0 milestone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.