build(hive): add ICEBERG_BUILD_HIVE option and skeleton#689
Open
MisterRaindrop wants to merge 1 commit into
Open
build(hive): add ICEBERG_BUILD_HIVE option and skeleton#689MisterRaindrop wants to merge 1 commit into
MisterRaindrop wants to merge 1 commit into
Conversation
Introduce a top-level ICEBERG_BUILD_HIVE CMake option (default OFF) and wire src/iceberg/catalog/hive/ into the build as a subdirectory. The new directory installs only iceberg_hive_export.h for now and mirrors the iceberg_rest_export.h pattern so that follow-up commits can add sources without further layout changes. The default OFF keeps builds without Apache Thrift unaffected. README's CMake options table is updated. First commit (C01) of the iceberg-cpp HiveCatalog port that follows iceberg-rust's iceberg-catalog-hms crate as a blueprint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a top-level ICEBERG_BUILD_HIVE CMake option (default OFF) and wire src/iceberg/catalog/hive/ into the build as a subdirectory. The new directory installs only iceberg_hive_export.h for now and mirrors the iceberg_rest_export.h pattern so that follow-up commits can add sources without further layout changes.
The default OFF keeps builds without Apache Thrift unaffected. README's CMake options table is updated.
First commit of the iceberg-cpp HiveCatalog that follows iceberg-rust's iceberg-catalog-hms crate as a blueprint.