Skip to content

refactor(table): remove orphan cleanup walk fallback#1307

Closed
Herrtian wants to merge 1 commit into
apache:mainfrom
Herrtian:codex/remove-orphan-cleanup-fallback
Closed

refactor(table): remove orphan cleanup walk fallback#1307
Herrtian wants to merge 1 commit into
apache:mainfrom
Herrtian:codex/remove-orphan-cleanup-fallback

Conversation

@Herrtian

Copy link
Copy Markdown
Contributor

Summary

  • Remove the unreachable LocalFS/blob fallback from orphan cleanup walkDirectory
  • Return an explicit error if a future IO implementation does not implement ListableIO
  • Add a regression test for that defensive error

Fixes #1276.

Tests

  • go test ./table -run TestWalkDirectoryRequiresListableIO -count=1

I also tried the broader orphan-cleanup subset on Windows; it currently fails in existing path-normalization tests that expect S3 URL paths with / while Windows produces escaped backslashes (%5C).

@Herrtian

Herrtian commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Closing this draft.

@Herrtian Herrtian closed this Jul 2, 2026
@Herrtian Herrtian deleted the codex/remove-orphan-cleanup-fallback branch July 2, 2026 15:23
@Herrtian Herrtian changed the title [codex] refactor(table): remove orphan cleanup walk fallback refactor(table): remove orphan cleanup walk fallback Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: remove the dead reflection fallback in orphan-cleanup walkDirectory

1 participant