Add SkipIfReferenced flag to removeSnapshotsUpdate#722
Open
dhananjaykrutika wants to merge 1 commit intoapache:mainfrom
Open
Add SkipIfReferenced flag to removeSnapshotsUpdate#722dhananjaykrutika wants to merge 1 commit intoapache:mainfrom
dhananjaykrutika wants to merge 1 commit intoapache:mainfrom
Conversation
ExpireSnapshots computes candidate snapshots for deletion at time T1, but by the time CommitTable applies the update at T2, a concurrent client might link one of these snapshots to a new branch or tag. Without protection, the snapshot is deleted and its new ref is silently cleaned up. This change adds a SkipIfReferenced flag to removeSnapshotsUpdate. When set, Apply() filters out any snapshot that is still referenced before calling RemoveSnapshots(). ExpireSnapshots sets this flag via SetSkipIfReferenced(). The default behavior (SkipIfReferenced=false) is unchanged: snapshots are removed and orphaned refs are silently cleaned up, preserving backward compatibility with explicit client-driven remove-snapshot updates.
Member
|
does |
Contributor
Author
No, it doesn't. And that's precisely where the problem lies. I started a discussion thread at https://lists.apache.org/thread/bx4vfclvpjh1osj3g1jlsr0zfowkb6xz to explore possible solutions. The goal was to gather community input on whether introducing skip-if-referenced would improve the spec and align better with real-world usage patterns. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExpireSnapshots computes candidate snapshots for deletion at time T1, but by the time CommitTable applies the update at T2, a concurrent client might link one of these snapshots to a new branch or tag. Without protection, the snapshot is deleted and its new ref is silently cleaned up.
This change adds a SkipIfReferenced flag to removeSnapshotsUpdate. When set, Apply() filters out any snapshot that is still referenced before calling RemoveSnapshots(). ExpireSnapshots sets this flag via SetSkipIfReferenced().
The default behavior (SkipIfReferenced=false) is unchanged: snapshots are removed and orphaned refs are silently cleaned up, preserving backward compatibility with explicit client-driven remove-snapshot updates.