feat: Add support for rolling back to timestamp #2879
+182
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Looks like Test Infra failed need to retrigger tests. |
jayceslesar
reviewed
Jan 19, 2026
Contributor
jayceslesar
left a comment
jayceslesar
left a comment
There was a problem hiding this comment.
just a couple of suggestions and the tests also look good!
Comment on lines
+477
to
+478
| def latest_ancestor_before_timestamp(table_metadata: TableMetadata, timestamp_ms: int) -> Snapshot | None: | ||
| """Find the latest ancestor snapshot whose timestamp is before the provided timestamp. |
Contributor
There was a problem hiding this comment.
It might be nice from a users perspective to allow this to be a datetime as well? Does differ from the java impl though...
Comment on lines
+490
to
+493
| for ancestor in ancestors_of(table_metadata.current_snapshot(), table_metadata): | ||
| if timestamp_ms > ancestor.timestamp_ms > result_timestamp: | ||
| result = ancestor | ||
| result_timestamp = ancestor.timestamp_ms |
Contributor
There was a problem hiding this comment.
what about using a max(filter(...)) statement here? I think a little easier to follow than the double greater than expression?
Contributor
There was a problem hiding this comment.
maybe not, this does match the java
nssalian
reviewed
Jan 20, 2026
|
|
||
| return self.set_current_snapshot(snapshot_id=snapshot_id) | ||
|
|
||
| def rollback_to_timestamp(self, timestamp_ms: int) -> ManageSnapshots: |
Contributor
There was a problem hiding this comment.
could add support for datetime too.
Co-authored-by: Chinmay Bhat <12948588+chinmay-bhat@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This PR adds the ability to rollback a table to a ancestoral snapshot given a timestamp. Some of this work was also done in #758, and is a progress pr to be merged after #2871 & #2878. This is standalone from the other changes but it makes use of the helpers in the other prs.
Additionally, adding some more tests.
Are these changes tested?
Yes
Are there any user-facing changes?
New API for meta