dep: upgrade pyiceberg-core to 0.8.0 and datafusion to 51 #2928
+27
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinjqliu
changed the title
nssalian
reviewed
Jan 20, 2026
nssalian
approved these changes
Jan 20, 2026
geruh
reviewed
Jan 20, 2026
Fokko
approved these changes
Jan 20, 2026
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Sweet! Thanks @kevinjqliu for fixing this right away, and thanks @nssalian and @geruh for the quick review 🚀
kevinjqliu
pushed a commit
that referenced
this pull request
Jan 20, 2026
<!--
Thanks for opening a pull request!
-->
<!-- In the case this PR will resolve an issue, please replace
${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
<!-- Closes #${GITHUB_ISSUE_ID} -->
# Rationale for this change
In #2928, the `uv.lock` wasn't generated correctly after a dependency
change.
Adding the following changes:
1. `make uv-lock` to generate one when modifying dependencies
2. `make uv-lock-check` to check if the `uv.lock` is up to date
3. Adding a pre-commit config to check the `uv.lock` and fail if not
updated correctly (uses 2.)
4. Documentation change in `mkdocs/docs/contributing.md` to add
instructions for contributors.
## Are these changes tested?
Locally.
Added some of the dependencies in #2928 without modifying the lock file
and ran `pre-commit run --all-files` to observe the following failure
message
```
uv lock file check.......................................................Failed
- hook id: uv-lock-check
- exit code: 2
uv lock --check
Resolved 221 packages in 93ms
The lockfile at `uv.lock` needs to be updated, but `--check` was provided. To update the lockfile, run `uv lock`.
make: *** [uv-lock-check] Error 1
```
## Are there any user-facing changes?
No. Useful for contributions that change versions/ dependencies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Update pyiceberg-core to the latest release, 0.8.0
Also update datafusion to match the version iceberg-rust uses, v51
https://github.com/apache/iceberg-rust/blob/v0.8.0/Cargo.toml#L65
Pulled in #2749 as well. Otherwise CI will fail.
register_table_providerhas been deprecated: https://datafusion.apache.org/python/autoapi/datafusion/context/index.html#datafusion.context.SessionContext.register_table_providerAre these changes tested?
Are there any user-facing changes?