improve dockerfile for better caching #2930
Merged
+51
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
approved these changes
Jan 20, 2026
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| services: |
Contributor
There was a problem hiding this comment.
There is also a yaml sort hook, but I'm not sure if it will improve readability: https://github.com/leehambley/pre-commit-sort-yaml-keys
Contributor
Author
There was a problem hiding this comment.
ty! i can look into this
raulcd
approved these changes
Jan 20, 2026
Member
raulcd
left a comment
raulcd
left a comment
There was a problem hiding this comment.
The changes on the Dockerfile's look great. Thanks for the work @kevinjqliu
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Reorder Dockerfile commands for better caching
All files has the same functionalities, just reordered.
Are these changes tested?
Are there any user-facing changes?