feat(scan): implement size-based file scan task planning#2031
Open
xbattlax wants to merge 1 commit intoapache:mainfrom
Open
feat(scan): implement size-based file scan task planning#2031xbattlax wants to merge 1 commit intoapache:mainfrom
xbattlax wants to merge 1 commit intoapache:mainfrom
Conversation
db0844e to
f2193b4
Compare
f2193b4 to
945a8ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement size-based file scan task planning for iceberg-rust, addressing issue #128.
Changes
Add
crates/iceberg/src/scan/bin_packing.rswith:BinPackingStream<S>for async streaming (memory efficient)CombinedScanTaskgrouping for balanced parallel executionUpdate
crates/iceberg/src/scan/context.rs:split_offsets(Parquet row group boundaries)Update
crates/iceberg/src/scan/mod.rs:with_split_target_size(),with_split_open_file_cost(),with_split_lookback()builder methodsplan_tasks()method returningCombinedScanTaskStreamUpdate
crates/iceberg/src/scan/task.rs:CombinedScanTaskstruct andCombinedScanTaskStreamtypeNotes
This matches the Java Iceberg implementation's
TableScanUtil.planTasks()functionality:Closes #128