Skip to content

fix: Interpret s3tables warehouse as table_location not metadata loca… #2115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emkornfield wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Interpret s3tables warehouse as table_location not metadata loca… #2115

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e587052
fix: Interpret s3tables warehouse as table_location not metadata loca…
emkornfield Feb 5, 2026
f5b64e7
wip
emkornfield Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions crates/catalog/s3tables/src/catalog.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,9 +448,9 @@ impl Catalog for S3TablesCatalog {
.await
.map_err(from_aws_sdk_error)?;

// prepare metadata location. the warehouse location is generated by s3tables catalog,
// prepare table location. the warehouse location is generated by s3tables catalog,
// which looks like: s3://e6c9bf20-991a-46fb-kni5xs1q2yxi3xxdyxzjzigdeop1quse2b--table-s3
let metadata_location = match &creation.location {
let table_location = match &creation.location {
Some(_) => {
return Err(Error::new(
ErrorKind::DataInvalid,
Expand All @@ -467,16 +467,17 @@ impl Catalog for S3TablesCatalog {
.send()
.await
.map_err(from_aws_sdk_error)?;
let warehouse_location = get_resp.warehouse_location().to_string();
MetadataLocation::new_with_table_location(warehouse_location).to_string()
get_resp.warehouse_location().to_string()
}
};

// write metadata to file
creation.location = Some(metadata_location.clone());
creation.location = Some(table_location.clone());
let metadata = TableMetadataBuilder::from_table_creation(creation)?
.build()?
.metadata;
let metadata_location =
MetadataLocation::new_with_table_location(table_location).to_string();
metadata.write_to(&self.file_io, &metadata_location).await?;

// update metadata location
Expand Down
Loading