fix(writer): validate equality delete field ids#2723
Open
u70b3 wants to merge 1 commit into
Open
Conversation
ef457cc to
a770760
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
RecordBatchProjectorbehavior for unsupported field types and map/list reachability.Are these changes tested?
cargo test -p iceberg test_equality_delete_rejects_empty_equality_ids --libcargo test -p iceberg test_equality_delete_rejects_duplicate_equality_ids --libcargo test -p iceberg test_equality_delete_rejects_missing_equality_id --libcargo test -p iceberg test_equality_delete_unreachable_column --libcargo test -p iceberg test_equality_delete_with_nullable_field --libcargo test -p iceberg equality_delete --libcargo fmt --checkcargo test -p iceberg --libcargo clippy -p iceberg --all-features --lib --tests -- -D warningsmake checkmake unit-testdocker compose -f dev/docker-compose.yaml up -d --build --waitmake nextest(1832 passed, 0 skipped)Note: the Docker-backed run used local mirror substitutions for image and Python package downloads because direct pulls from Docker Hub timed out in my environment. No compose-file changes are included in this PR.