Skip to content

Spark: Stop streaming queries before dropping table in streaming read test teardown #16976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
huan233usc wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −3
Draft

Spark: Stop streaming queries before dropping table in streaming read test teardown #16976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestStructuredStreamingRead3.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,11 @@ public void stopStreams() throws TimeoutException {
}

@AfterEach
public void removeTables() {
public void removeTables() throws TimeoutException {
// Stop active streams before dropping the table. In async mode the planner's background
// thread keeps refreshing the table from the catalog; dropping the table while that thread
// is alive lets those refreshes contend with DROP TABLE and stall teardown for seconds.
stopStreams();
sql("DROP TABLE IF EXISTS %s", tableName);
}

Expand Down
6 changes: 5 additions & 1 deletion ...4.0/spark/src/test/java/org/apache/iceberg/spark/source/TestStructuredStreamingRead3.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,11 @@ public void stopStreams() throws TimeoutException {
}

@AfterEach
public void removeTables() {
public void removeTables() throws TimeoutException {
// Stop active streams before dropping the table. In async mode the planner's background
// thread keeps refreshing the table from the catalog; dropping the table while that thread
// is alive lets those refreshes contend with DROP TABLE and stall teardown for seconds.
stopStreams();
sql("DROP TABLE IF EXISTS %s", tableName);
}

Expand Down
6 changes: 5 additions & 1 deletion ...4.1/spark/src/test/java/org/apache/iceberg/spark/source/TestStructuredStreamingRead3.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,11 @@ public void stopStreams() throws TimeoutException {
}

@AfterEach
public void removeTables() {
public void removeTables() throws TimeoutException {
// Stop active streams before dropping the table. In async mode the planner's background
// thread keeps refreshing the table from the catalog; dropping the table while that thread
// is alive lets those refreshes contend with DROP TABLE and stall teardown for seconds.
stopStreams();
sql("DROP TABLE IF EXISTS %s", tableName);
}

Expand Down