fix(connectors): increase poll budget in fetch_rows_as to fix flaky restart test#3106
Open
atharvalade wants to merge 5 commits intoapache:masterfrom
Open
fix(connectors): increase poll budget in fetch_rows_as to fix flaky restart test#3106atharvalade wants to merge 5 commits intoapache:masterfrom
atharvalade wants to merge 5 commits intoapache:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3106 +/- ##
=============================================
- Coverage 72.76% 54.33% -18.43%
Complexity 943 943
=============================================
Files 1117 1115 -2
Lines 96368 86100 -10268
Branches 73544 63275 -10269
=============================================
- Hits 70119 46784 -23335
- Misses 23702 36776 +13074
+ Partials 2547 2540 -7
🚀 New features to boost your workflow:
|
…estart test Use full DEFAULT_POLL_INTERVAL_MS (50ms) instead of dividing by 5 (10ms), matching other polling helpers.
atharvalade
force-pushed
the
fix/flaky-postgres-restart-test
branch
from
1fd50cc to
4fc168e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3105
Rationale
restart_sink_connector_continues_processingis flaky in CI due to an insufficient polling budget infetch_rows_as.What changed?
fetch_rows_asusedDEFAULT_POLL_INTERVAL_MS / 5(10ms) per attempt, giving it a total polling budget of ~1s — far shorter than the ~5s budget of every other polling helper (wait_for_sink_status,wait_for_table). On loaded CI runners the postgres sink connector cannot always finish processing within 1s after a restart.Changed to use the full
DEFAULT_POLL_INTERVAL_MS(50ms), matching the other helpers. The function still returns immediately once the expected row count is reached, so passing tests are not slowed down.Local Execution