IGNITE-28303 Clients: do not retry authentication errors#7955
Merged
ptupitsyn merged 12 commits intoapache:mainfrom Apr 14, 2026
Merged
IGNITE-28303 Clients: do not retry authentication errors#7955ptupitsyn merged 12 commits intoapache:mainfrom
ptupitsyn merged 12 commits intoapache:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses IGNITE-28303 by ensuring the Java thin client does not retry connection attempts when the server rejects authentication (e.g., invalid credentials), avoiding repeated rejected sessions and unnecessary load.
Changes:
- Add a regression test asserting that invalid credentials result in a single rejected session (no retries even with a retry policy configured).
- Adjust client channel handshake/response completion logic to propagate server-side
TraceableExceptions (including auth failures) instead of re-wrapping them as connection/handshake errors that can trigger retries.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| modules/client/src/test/java/org/apache/ignite/client/ClientAuthenticationTest.java | Adds a test verifying bad credentials are not retried (server sees exactly one rejected session). |
| modules/client/src/main/java/org/apache/ignite/internal/client/TcpClientChannel.java | Propagates TraceableException from response completion/handshake to prevent retry logic from treating auth failures as retriable connection errors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
isapego
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix authn error handing in .NET and Java clients:
RetryPolicyfor those errorshttps://issues.apache.org/jira/browse/IGNITE-28303