Skip to content

IGNITE-13286 Support Java records in binary marshaller #13391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kush2439p wants to merge 1 commit into
base: ignite-2.17
Choose a base branch
from
Draft

IGNITE-13286 Support Java records in binary marshaller #13391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion modules/core/src/main/java/org/apache/ignite/internal/binary/BinaryClassDescriptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ public class BinaryClassDescriptor {
initialSerializer = serializer;

// If serializer is not defined at this point, then we have to use OptimizedMarshaller.
useOptMarshaller = serializer == null || isGeometryClass(cls);
useOptMarshaller = serializer == null || isGeometryClass(cls) || isRecord(cls);

// Reset reflective serializer so that we rely on existing reflection-based serialization.
if (serializer instanceof BinaryReflectiveSerializer)
Expand Down Expand Up @@ -1096,6 +1096,21 @@ Constructor<?> ctor() {
return ctor;
}

/**
* Checks whether a class is a Java record without requiring a Java 16 runtime at compile time.
*
* Records are immutable and the binary marshaller cannot restore their final fields. Java serialization,
* used by the optimized marshaller, supports serializable records starting with Java 16.
*
* @param cls Class to check.
* @return {@code True} if the class is a record.
*/
private static boolean isRecord(Class<?> cls) {
Class<?> superCls = cls.getSuperclass();

return superCls != null && "java.lang.Record".equals(superCls.getName());
}

/**
* @param cls Class.
* @return Constructor.
Expand Down
Loading