IGNITE-28528 Move the start request conversion out of the message - #13439
Closed
anton-vinogradov wants to merge 1 commit into
Closed
IGNITE-28528 Move the start request conversion out of the message#13439anton-vinogradov wants to merge 1 commit into
anton-vinogradov wants to merge 1 commit into
Conversation
StartRequestData no longer marshals itself: GridContinuousProcessor does it, where the sender id, the deployment and the right thread are already at hand. The message keeps only its fields, and the marshaller is now picked where we marshal. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Possible compatibility issues. Please, check rolling upgrade casesThis PR modifies protected classes (with Order annotation). Affected files:
|
Contributor
Author
|
Superseded by #13440, which revises the marshalling instead of moving the conversion code around: the message now states the deployment it carries, and the class loader is resolved once, in the deployment manager. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StartRequestDatamarshalled itself:marshal(GridKernalContext)andunmarshal(GridKernalContext, UUID)picked the marshaller, resolved the peer deployment and ran the p2p hooks — all from inside the message. This moves that work toGridContinuousProcessor, the only place that has the sender id, the deployment and a thread where marshalling is allowed. The message keeps its fields and nothing else.Nothing changes on the wire: the same eight
@Orderfields in the same order, the same marshaller, the same call order. What changes is where the marshaller is taken from — which is what IGNITE-28940 needs to switch it per transport.Two details worth a look:
p2pUnmarshal. That order matters:p2pUnmarshalthrows when the deployment is unavailable, and the caller still reads the handler afterwards to report the failure and stop the routine.nodeFilterandhndbecame package-private, like the other fields of the class; the processor lives in the same package and reads them directly, as it already did withnodeFilterBytesandhndBytes.Tested:
CacheContinuousQueryFilterDeploymentFailedTest,GridCacheContinuousQueryNodesFilteringTest,CacheContinuousQueryDeploymentToClientTest,CacheContinuousQueryAsyncFilterListenerTest,CacheContinuousQueryEventBufferTest,GridEventConsumeSelfTest— green, checkstyle clean.