Skip to content

IGNITE-28963 - #13451

Open
petrov-mg wants to merge 4 commits into
apache:masterfrom
petrov-mg:IGNITE-28963
Open

IGNITE-28963#13451
petrov-mg wants to merge 4 commits into
apache:masterfrom
petrov-mg:IGNITE-28963

Conversation

@petrov-mg

Copy link
Copy Markdown
Contributor

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

  • There is a single JIRA ticket related to the pull request.
  • The web-link to the pull request is attached to the JIRA ticket.
  • The JIRA ticket has the Patch Available state.
  • The pull request body describes changes that have been made.
    The description explains WHAT and WHY was made instead of HOW.
  • The pull request title is treated as the final commit message.
    The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • A reviewer has been mentioned through the JIRA comments
    (see the Maintainers list)
  • The pull request has been checked by the Teamcity Bot and
    the green visa attached to the JIRA ticket (see tab PR Check at TC.Bot - Instance 1 or TC.Bot - Instance 2)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

@github-actions

github-actions Bot commented Aug 8, 2026

Copy link
Copy Markdown

Possible compatibility issues. Please, check rolling upgrade cases

This PR modifies protected classes (with Order annotation).
Changes to these classes can break rolling upgrade compatibility.

Affected files:

  • modules/core/src/main/java/org/apache/ignite/plugin/security/SecurityBasicPermissionSet.java
  • modules/core/src/test/java/org/apache/ignite/internal/codegen/MessageProcessorTest.java
  • modules/core/src/test/java/org/apache/ignite/internal/direct/TestNestedContainersMessage.java

/** */
@Test
public void testEnumSetMessage() {
Compilation compilation = compile("TestEnumSetMessage.java");

@shishkovilja shishkovilja Aug 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. We should add test for EnumSet, annotated with CustomEnumMapper.
  2. We should add test, that checks exception, when two different EnumSet are used in some Map, eg.:
    Map<EnumSet<Enum1>, EnumSet<Enum2>>.
    See MessageProcessorTets#testEnumMapperCannotBeTwoEnums (typo in the method name) as example.

This can be done in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants