IGNITE-27977 Refactor bytes serialization for DataStreamerRequest #13454
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.ignite.internal.processors.datastreamer; | ||
|
|
||
| import org.apache.ignite.internal.Marshalled; | ||
| import org.apache.ignite.internal.Order; | ||
| import org.apache.ignite.internal.UseBinaryMarshaller; | ||
| import org.apache.ignite.plugin.extensions.communication.Message; | ||
| import org.apache.ignite.stream.StreamReceiver; | ||
|
|
||
| /** | ||
| * The receiver of a streamer on its way to the nodes that own the data: a user object here, its serialized form on | ||
| * the wire. One instance serves every batch of a streamer, so the receiver is marshalled once and the batches share | ||
| * the result; a streamer given another receiver builds another instance. | ||
| */ | ||
| @UseBinaryMarshaller | ||
| public class StreamReceiverMessage implements Message { | ||
| /** */ | ||
| @Marshalled("rcvrBytes") | ||
| StreamReceiver<?, ?> rcvr; | ||
|
|
||
| /** | ||
| * Serialized {@link #rcvr}, written by whichever batch is marshalled first and read by the rest. Those batches | ||
| * leave on different threads, hence the {@code volatile}: a reader seeing the reference before the contents would | ||
| * skip the marshalling and send a half-written array. | ||
| */ | ||
| @Order(0) | ||
| volatile byte[] rcvrBytes; | ||
|
Contributor
There was a problem hiding this comment. Should
Contributor
Author
There was a problem hiding this comment. I don't think so: the marker means the opposite of what this class does.
If what you had in mind is the side effects the marker brings — the marshaller becoming mandatory at registration, and |
||
|
|
||
| /** Empty constructor. */ | ||
| public StreamReceiverMessage() { | ||
| // No-op. | ||
| } | ||
|
|
||
| /** @param rcvr Receiver. */ | ||
| StreamReceiverMessage(StreamReceiver<?, ?> rcvr) { | ||
| this.rcvr = rcvr; | ||
| } | ||
|
|
||
| /** @return Receiver. */ | ||
| StreamReceiver<?, ?> receiver() { | ||
| return rcvr; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What changed? One external, not automated marshalling changed with another.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The call stays external, but what it does is not the same.
Before, this line picked the marshaller itself —
marshwasctx.marshaller()— and deserialized one particular field. That is what makes a blob a hole for IGNITE-28940: the field decides its own marshaller, whatever the transport decides. Now the processor only starts the read; which fields are touched, and with which marshaller, is decided by the generated marshaller that the message factory holds for this type (@UseBinaryMarshalleronStreamReceiverMessageselects the schema-aware one). The processor no longer knows that the receiver has a serialized form at all, and the entries of the same request are read by the same pass.What cannot become automatic here is the moment of the call. The message is a
DeferredUnmarshalMessage: its class loader is known only at this point — the grid loader under forced local deployment, the sender's global deployment otherwise — and a missing deployment has to travel back to the sender as a response instead of being thrown on the inbound thread.GridEventStorageManager,GridJobProcessor,GridTaskWorkerandGridCacheIoManagercallMessageMarshalling.unmarshalexplicitly for the same reason.