[C++][CMake] Fix install/export targets and Windows runtime handling#819
Open
tanmoyPaul12 wants to merge 1 commit intoapache:mainfrom
Open
[C++][CMake] Fix install/export targets and Windows runtime handling#819tanmoyPaul12 wants to merge 1 commit intoapache:mainfrom
tanmoyPaul12 wants to merge 1 commit intoapache:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #819 +/- ##
============================================
+ Coverage 77.17% 77.18% +0.01%
Complexity 607 607
============================================
Files 84 85 +1
Lines 8854 8858 +4
Branches 1043 1043
============================================
+ Hits 6833 6837 +4
Misses 1781 1781
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Hi @tanmoyPaul12 Thanks for the update! This PR improves the installation paths (especially for Windows), but it doesn't fully resolve #810 yet. To fully support find_package(GraphAr) and the requested distribution goals, we still need:
Could you please address these points? |
Author
|
@yangxk1 I’ll update this PR to:
Thanks for the clarification — I’ll follow up with the changes shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #810
Reason for this PR
The current CMake installation logic in GraphAr does not reliably support
library distribution and downstream consumption, especially on Windows.
This PR addresses the CMake install and export issues discussed in #810
and makes runtime installation behavior consistent across platforms.
What changes are included in this PR?
graphartargetinstall(TARGETS graphar ...)rulecmake --installAre these changes tested?
cmake --build . --config Releasecmake --install . --config ReleaseAre there any user-facing changes?
No. This change affects CMake install and packaging behavior only and does not
modify GraphAr APIs or runtime behavior.