verify-action-build: print a green attestation note with assumptions#977
Merged
Conversation
When a downloader script (or action.yml run block) verifies its download via `gh attestation verify`, the scan already passed it as "verification present in file" — but gave no signal that the strongest mechanism, GitHub build attestation, was the one detected. Add an explicit green note naming attestation verification, plus a dim "Assumptions" block making the static-scan limitations clear: it confirms the verify command is present, but does not run the installer, does not confirm the call targets the downloaded artifact, and cannot detect fail-open behaviour (verification skipped/warned when `gh` is absent). Behaviour is otherwise unchanged — pass/fail classification is identical; this only adds a clearer, caveated green signal. Covered by a regression test modelled on the untitaker/hyperlink installer shape. Generated-by: Claude Opus 4.8 (1M context), Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When a downloader script (or an
action.ymlrun block) verifies its download viagh attestation verify,verify-action-buildalready passed it as "verification present in file" — but gave no signal that the strongest mechanism, GitHub build attestation, was the one detected.This adds an explicit green note naming attestation verification, plus a
dimAssumptions block that spells out the static-scan limitations:Why
Surfaced while triaging #975 (dependabot bump of
untitaker/hyperlinkto 0.3.2, whose installer addedgh attestation verify). The scan correctly passed it, but a reviewer couldn't tell which mechanism satisfied the check, nor what the check did and did not prove. The note makes the strongest signal visible and its assumptions explicit.Scope
action.ymlrun blocks and referenced installer scripts.untitaker/hyperlinkinstaller shape.Full suite:
147 passed.🤖 Generated with Claude Code