fix: correctly handle null values and empty strings in column decoder #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix numeric decoders (INT32/INT64/FLOAT/DOUBLE) to always read values from stream even for null positions, as server sends data for all positions - Fix binary decoder to handle empty string (length=0) without EOF error
There was a problem hiding this comment.
Pull request overview
This PR fixes null value and empty string handling in column decoders to prevent data stream misalignment errors. The changes ensure that numeric decoders always read values from the stream regardless of null indicators, and that the binary decoder properly handles empty strings without triggering EOF errors.
Changes:
- Removed null-skipping logic from Int32ArrayColumnDecoder (INT32, DATE, FLOAT types)
- Removed null-skipping logic from Int64ArrayColumnDecoder (INT64, TIMESTAMP, DOUBLE types)
- Added special handling for zero-length strings in BinaryArrayColumnDecoder to avoid EOF errors
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix column decoder to correctly handle null values and empty strings:
Numeric decoders: Always read values from stream even for null positions,
as server sends data for all positions. Skipping null positions causes stream
misalignment.
Binary decoder: Handle empty strings (length=0) without triggering EOF error.
Why are the changes needed?