Skip to content

Display data partition repair progress by providing a new SQL statement#17637

Merged
CRZbulabula merged 10 commits into
apache:masterfrom
zerolbsony:manually-trigger-repair-data-partiton-progress
Jun 30, 2026
Merged

Display data partition repair progress by providing a new SQL statement#17637
CRZbulabula merged 10 commits into
apache:masterfrom
zerolbsony:manually-trigger-repair-data-partiton-progress

Conversation

@zerolbsony

@zerolbsony zerolbsony commented May 11, 2026

Copy link
Copy Markdown
Contributor

Use the sql to display progress:
SHOW REPAIR DATA PARTITION TABLE PROGRESS

@CRZbulabula CRZbulabula left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feature — the end-to-end plumbing follows the existing statement pipeline well. I left inline comments on specific lines. One important item cannot be anchored inline because the file is not touched by this PR, so I'm raising it here:

[Must fix] iotdb-core/antlr/src/main/antlr4/org/apache/iotdb/db/qp/sql/IdentifierParser.g4 (keyWords rule, ~line 191)

The new PROGRESS lexer token added in SqlLexer.g4 is not registered in the keyWords rule. REPAIR, PARTITION, and TABLE are all present there, but PROGRESS is missing. As a result, any existing identifier or timeseries node named progress (e.g. SELECT progress FROM root.x or root.sg.d.progress) will fail to parse after this change — a backward-incompatible regression. Please add | PROGRESS to the list, alphabetically between PROCESSLIST and PROCESSOR:

    | PROCESSLIST
    | PROGRESS
    | PROCESSOR

@CRZbulabula CRZbulabula merged commit 522c31c into apache:master Jun 30, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants