Conversation
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #17665 +/- ##
============================================
+ Coverage 41.21% 41.49% +0.27%
Complexity 318 318
============================================
Files 5258 5287 +29
Lines 366348 370001 +3653
Branches 47389 47858 +469
============================================
+ Hits 151004 153514 +2510
- Misses 215344 216487 +1143 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
luoluoyuyu
left a comment
luoluoyuyu
left a comment
There was a problem hiding this comment.
Review summary
Adds PipeSchemaRegionWritePlanEventBatch to batch schema-region write plan events before sink transfer, with histogram metrics for batch size and cost.
Please fix CI and address the metric setter naming inline before merge.
| return BytesUtils.concatByteArray( | ||
| byteArrayOutputStream.toByteArray(), planNode.serializeToByteBuffer().array()); | ||
| byteArrayOutputStream.toByteArray(), getBytes(serializedPlanNode)); | ||
| } | ||
| } | ||
|
|
||
| private static byte[] getBytes(final ByteBuffer byteBuffer) { | ||
| final ByteBuffer duplicateBuffer = byteBuffer.duplicate(); | ||
| final byte[] bytes = new byte[duplicateBuffer.remaining()]; | ||
| duplicateBuffer.get(bytes); | ||
| return bytes; | ||
| } |
There was a problem hiding this comment.
Is it possible to avoid copying by extending BytesUtils.concatByteArra?
There was a problem hiding this comment.
Good point. I avoided the extra intermediate copy on the IoTDB side by filling the final byte[] directly from the PublicBAOS backing buffer and the duplicated ByteBuffer's remaining bytes. Extending BytesUtils itself would require a tsfile-side API change, so I kept the change local to this PR.
|
3 participants
Description
As the title said.
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR